[GitHub] mistercrunch commented on a change in pull request #3439: Allowing to set the sort order during query with "group by"

[gi...@git.apache.org]

mistercrunch commented on a change in pull request #3439: Allowing to set the sort order during query with "group by"
URL: https://github.com/apache/incubator-superset/pull/3439#discussion_r138396741
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -137,6 +137,9 @@ def query_obj(self):
         row_limit = int(
             form_data.get("row_limit") or config.get("ROW_LIMIT"))
 
+        # default order direction
+        order_desc = form_data.get("order_desc", True)
 
 Review comment:
   I feel like there's a control (in controls.jsx) missing in this PR (?)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services