You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/02/27 21:13:30 UTC
Review Request 31558: Removing --rollback-on-failure from aurora
restart.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1020
https://issues.apache.org/jira/browse/AURORA-1020
Repository: aurora
Description
-------
Removing --rollback-on-failure from aurora restart.
Diffs
-----
src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
Diff: https://reviews.apache.org/r/31558/diff/
Testing
-------
./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
Thanks,
Maxim Khutornenko
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74593
-----------------------------------------------------------
Ship it!
Master (e8a0a9f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74571
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Feb. 27, 2015, 8:20 p.m., Zameer Manji wrote:
> > Just to be clear, this is because it doesn't make sense to have rollback with restarts right?
Yeah, there is nothing to rollback to in case of restarts that by definition use the same task config.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74573
-----------------------------------------------------------
On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74573
-----------------------------------------------------------
Ship it!
Just to be clear, this is because it doesn't make sense to have rollback with restarts right?
- Zameer Manji
On Feb. 27, 2015, 12:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 12:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74581
-----------------------------------------------------------
Master (443f668) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31558: Removing --rollback-on-failure from aurora
restart.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74586
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 8:13 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing --rollback-on-failure from aurora restart.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92
> src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51
>
> Diff: https://reviews.apache.org/r/31558/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>