You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bruno P. Kinoshita (Jira)" <ji...@apache.org> on 2019/10/16 07:45:00 UTC
[jira] [Updated] (IMAGING-165) TiffReader.Collector adds values to
a field List but never uses it
[ https://issues.apache.org/jira/browse/IMAGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno P. Kinoshita updated IMAGING-165:
---------------------------------------
Assignee: Bruno P. Kinoshita
> TiffReader.Collector adds values to a field List<TiffField> but never uses it
> -----------------------------------------------------------------------------
>
> Key: IMAGING-165
> URL: https://issues.apache.org/jira/browse/IMAGING-165
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: TIFF
> Reporter: Michael Groß
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: Discussion
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> org.apache.commons.imaging.formats.tiff.TiffReader.Collector adds values to a field List<TiffField> but never uses it. This could be the cause of some problems reported elsewhere.
> TiffReader contains an embedded class named Collector. This class has a private field named
> {noformat}
> private static class Collector implements Listener {
> private final List<TiffField> fields = new ArrayList<TiffField>();
> {noformat}
> There are values added in a method named
> {noformat}
> public boolean addField(final TiffField field) {
> fields.add(field);
> return true;
> }
> {noformat}
> This method is the only which uses this field so these values are never used. Is there a getter missing? Or was it intended to use these values in class TiffContents like "tiffHeader" and "directories"?
> {noformat}
> public TiffContents getContents() {
> return new TiffContents(tiffHeader, directories);
> }
> {noformat}
> At least the method "addField" seems unused but necessary to implement the "Listener" interface.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)