You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/16 09:06:08 UTC
[GitHub] [ozone] guihecheng opened a new pull request, #3523: HDDS-6890. EC: Fix potential wrong replica read with over-replicated container.
guihecheng opened a new pull request, #3523:
URL: https://github.com/apache/ozone/pull/3523
Co-authored-by: Uma Maheswara Rao G <um...@cloudera.com>
## What changes were proposed in this pull request?
Fix potential wrong replica read with over-replicated container.
The problem is due to that an EC pipeline with multiple DNs is returned and used with the first DN picked while refreshing pipeline on read error(Read error is due to concurrent redundant EC container replica deletion, e.g. EC 10+4 with 18 replicas),
but the right behavior should be pick the DN with the same replicaIndex and build a standalone pipeline for retry.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6890
## How was this patch tested?
To be verified manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #3523: HDDS-6890. EC: Fix potential wrong replica read with over-replicated container.
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged PR #3523:
URL: https://github.com/apache/ozone/pull/3523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #3523: HDDS-6890. EC: Fix potential wrong replica read with over-replicated container.
Posted by GitBox <gi...@apache.org>.
guihecheng commented on PR #3523:
URL: https://github.com/apache/ozone/pull/3523#issuecomment-1157649681
> I think this change looks good. I think it will fix the issue.
>
> A test to reproduce the problem is likely too difficult, but I'd like to see a test that executes the new refresh wrapper.
>
> Do you think we could create a protected method called something like:
>
> ```
> Function<BlockID, Pipeline> ecPipelineRefreshFunction(BlockId blockID, int replicaIndex, Function<BlockID, Pipeline> refreshFunction) {
> ...
> }
> ```
>
> Then we can create a simple unit test that creates a simple refresh function that returns an hardcoded ECPipeline object, that is used by our new wrapper, and validate the correct node is selected based on the index?
Oh, that's a good idea to cover this small function with test, Thanks, I'll update soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #3523: HDDS-6890. EC: Fix potential wrong replica read with over-replicated container.
Posted by GitBox <gi...@apache.org>.
guihecheng commented on PR #3523:
URL: https://github.com/apache/ozone/pull/3523#issuecomment-1157418360
cc @umamaheswararao @sodonnel for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org