You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jwitko (via GitHub)" <gi...@apache.org> on 2023/02/14 19:55:53 UTC
[GitHub] [druid] jwitko opened a new pull request, #13806: helm: Update Ingress and HPA manifests to support modern K8s versions
jwitko opened a new pull request, #13806:
URL: https://github.com/apache/druid/pull/13806
Fixes #13536
Obsoletes #13538
This PR should only be merged after #13783 as it is forked off of that branch due to requiring some changes made there.
The chart version bump is incremental based off of other PRs like #13796 , #13783 , #13747
### Description
This helm chart is currently not compatible with some more modern K8s versions due to lack of support for updates resource API versions. This PR brings the chart more up to date by updating the Ingress and Horizontal Pod Autoscaler API versions to support newer API Versions but also maintain backwards compatibility.
#### Release note
Update Helm Chart Ingress and HPA manifests to support modern K8s versions
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [X] been self-reviewed.
- [X] added documentation for new or modified features or behaviors.
- [X] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [X] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] helm: Update Ingress and HPA manifests to support modern K8s versions (druid)
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on PR #13806:
URL: https://github.com/apache/druid/pull/13806#issuecomment-1932245152
This PR should definitely get reviewed. Please do not mark as stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on pull request #13806: helm: Update Ingress and HPA manifests to support modern K8s versions
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on PR #13806:
URL: https://github.com/apache/druid/pull/13806#issuecomment-1464127479
The failing test seems completely unrelated to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] helm: Update Ingress and HPA manifests to support modern K8s versions (druid)
Posted by "asdf2014 (via GitHub)" <gi...@apache.org>.
asdf2014 commented on PR #13806:
URL: https://github.com/apache/druid/pull/13806#issuecomment-1956194754
@jwitko Thanks for your contribution. As mentioned in PR [https://github.com/apache/druid/pull/15904](https://github.com/apache/druid/pull/15904), we have migrated the Helm Chart to a [new repository](https://github.com/asdf2014/druid-helm), you are welcome to raise up new PR there and we can maintain the Druid Helm Chart together in new repository. And this PR will closed soon. Thank you again for your understanding and collaboration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] helm: Update Ingress and HPA manifests to support modern K8s versions (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13806:
URL: https://github.com/apache/druid/pull/13806#issuecomment-1931002011
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] helm: Update Ingress and HPA manifests to support modern K8s versions (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13806:
URL: https://github.com/apache/druid/pull/13806#issuecomment-2068280871
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org