You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/11/16 10:23:27 UTC
Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5185
https://issues.apache.org/jira/browse/CLOUDSTACK-5185
Repository: cloudstack-git
Description
-------
Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
This issue arises when VM deployment has already failed in previous step.
Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
This change will indicate proper reason for test case failure.
Diffs
-----
test/integration/component/test_egress_fw_rules.py 0aed957
Diff: https://reviews.apache.org/r/15610/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/#review29008
-----------------------------------------------------------
Commit 249f853484f88f59bfeb2ccd114206c1ccd77bb8 in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=249f853 ]
CLOUDSTACK-5185: test_egress_fw_rules - failed the test case
if vm deployment failed instead of going on executing rest
- ASF Subversion and Git Services
On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15610/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5185
> https://issues.apache.org/jira/browse/CLOUDSTACK-5185
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
> This issue arises when VM deployment has already failed in previous step.
>
> Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
>
> This change will indicate proper reason for test case failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0aed957
>
> Diff: https://reviews.apache.org/r/15610/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/#review29009
-----------------------------------------------------------
Commit 80dfd0f97ec611d8dee63ad74f6f1ecf74647b99 in branch refs/heads/4.2 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80dfd0f ]
CLOUDSTACK-5185: test_egress_fw_rules - failed the test case
if vm deployment failed instead of going on executing rest
- ASF Subversion and Git Services
On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15610/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5185
> https://issues.apache.org/jira/browse/CLOUDSTACK-5185
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
> This issue arises when VM deployment has already failed in previous step.
>
> Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
>
> This change will indicate proper reason for test case failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0aed957
>
> Diff: https://reviews.apache.org/r/15610/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/#review29011
-----------------------------------------------------------
Ship it!
Committed to 4.2, 4.3 and master
- Girish Shilamkar
On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15610/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5185
> https://issues.apache.org/jira/browse/CLOUDSTACK-5185
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
> This issue arises when VM deployment has already failed in previous step.
>
> Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
>
> This change will indicate proper reason for test case failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0aed957
>
> Diff: https://reviews.apache.org/r/15610/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/#review29010
-----------------------------------------------------------
Ship it!
Committed to 4.2, 4.3 and master
- Girish Shilamkar
On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15610/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5185
> https://issues.apache.org/jira/browse/CLOUDSTACK-5185
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
> This issue arises when VM deployment has already failed in previous step.
>
> Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
>
> This change will indicate proper reason for test case failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0aed957
>
> Diff: https://reviews.apache.org/r/15610/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the
test case if vm deployment failed instead of going on executing rest of the
test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15610/#review29007
-----------------------------------------------------------
Commit 02c15528c8ad5a40998cc8d910560ce759c5d039 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=02c1552 ]
CLOUDSTACK-5185: test_egress_fw_rules - failed the test case
if vm deployment failed instead of going on executing rest
- ASF Subversion and Git Services
On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15610/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5185
> https://issues.apache.org/jira/browse/CLOUDSTACK-5185
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases from suite test_egress_fw_rules failed due to 'TestEgressFWRules' object has no attribute 'virtual_machine'.
> This issue arises when VM deployment has already failed in previous step.
>
> Test case should fail if VM deployment fails which could happen if there is setup issue. (Insufficient server capacity.)
>
> This change will indicate proper reason for test case failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 0aed957
>
> Diff: https://reviews.apache.org/r/15610/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>