[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #1891: doc(k8s): removed unnecessary configurations.

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891#discussion_r459378802



##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
 There are some yaml files for deploying apisix in Kubernetes.
 
 ### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
+
+- Run `config.sh` to generate apisix-gw-config-cm.yaml from the latest `config.yaml`

Review comment:
       to generate the `apisix-gw-config-cm.yaml`

##########
File path: kubernetes/config.sh
##########
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+export etcd_url='http://here_is_you_etcd_IP:2379'

Review comment:
       `http://$ETCD_IP_ADDRESS:2379`

##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
 There are some yaml files for deploying apisix in Kubernetes.
 
 ### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh

Review comment:
       We could use ``` to include keywords, e.g `etcd`

##########
File path: kubernetes/README.md
##########
@@ -56,7 +66,7 @@ or
 $ kubectl create configmap apisix-gw-config.yaml --from-file=../conf/config.yaml
 ```
 
-##### Note: you should modify etcd addr in config file `apisix-gw-config-cm.yaml` or `../conf/config.yaml` first
+##### Note: you should check etcd addr in config file `apisix-gw-config-cm.yaml` or `../conf/config.yaml` first, make sure the etcd addresses are right.

Review comment:
       `are correct`.

##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
 There are some yaml files for deploying apisix in Kubernetes.
 
 ### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
+
+- Run `config.sh` to generate apisix-gw-config-cm.yaml from the latest `config.yaml`
+
+```

Review comment:
       ```sh
   # if config.sh have no permission to execute, then execute `chmod +x config.sh` to generate apisix-gw-config-cm.yaml
   $ sh config.sh
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org