You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/07 06:28:13 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #6172: [Bug] Fix the bug of bucket shuffle join cause error paln
HappenLee opened a new pull request #6172:
URL: https://github.com/apache/incubator-doris/pull/6172
## Proposed changes
Fix the bug #6171
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6171) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6172: [Bug] Fix the bug of bucket shuffle join cause error paln
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #6172:
URL: https://github.com/apache/incubator-doris/pull/6172#discussion_r665089544
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -683,9 +678,14 @@ private boolean canBucketShuffleJoin(HashJoinNode node, PlanNode leftRoot,
DistributionInfo leftDistribution = leftScanNode.getOlapTable().getDefaultDistributionInfo();
if (leftDistribution instanceof HashDistributionInfo) {
+ // use the table_name + '-' + column_name as check condition
List<Column> leftDistributeColumns = ((HashDistributionInfo) leftDistribution).getDistributionColumns();
+ List<String> leftDistributeColumnNames = Lists.newArrayList();
+ for (Column col : leftDistributeColumns) {
+ leftDistributeColumnNames.add(leftTable.getName() + "-" + col.getName());
Review comment:
used to "."
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -696,18 +696,21 @@ private boolean canBucketShuffleJoin(HashJoinNode node, PlanNode leftRoot,
continue;
}
- SlotDescriptor leftSlot = lhsJoinExpr.unwrapSlotRef().getDesc();
-
- leftJoinColumns.add(leftSlot.getColumn());
- rightExprs.add(rhsJoinExpr);
+ SlotRef leftSlot = lhsJoinExpr.unwrapSlotRef();
+ if (leftSlot.getTable() instanceof OlapTable) {
+ // table name in SlotRef is not the really name. `select * from test as t`
+ // table name in SlotRef is `t`, but here we need is `test`.
+ leftJoinColumnNames.add(leftSlot.getTable().getName() + "-" + leftSlot.getColumnName());
Review comment:
used to '"."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6172: [Bug] Fix the bug of bucket shuffle join cause error paln
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6172:
URL: https://github.com/apache/incubator-doris/pull/6172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org