[jira] [Comment Edited] (THRIFT-3946) Java 1.5 compatibility broken for binary fields (java5 option)

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577692#comment-15577692 ] 

Jens Geyer edited comment on THRIFT-3946 at 10/15/16 8:52 AM:
--------------------------------------------------------------

Two questions:

1. Which one is more efficient? Or is there virtually no difference in performance at all?

2. Would it make sense to use {{clone()}} only when the {{java5}} option is specified, and use {{copyOf()}} otherwise?


was (Author: jensg):
Two questions:

1. Which one is more efficient?

2. Would it make sense to use {{clone()}} only when the {{(java5}} option is specified, and use {{copyOf()}} otherwise?

> Java 1.5 compatibility broken for binary fields (java5 option)
> --------------------------------------------------------------
>
>                 Key: THRIFT-3946
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3946
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Philip Hamer
>              Labels: java5
>         Attachments: thrift-3946-java5-binary-arrays-copyof.patch
>
>
> For binary fields, even with the java5 option (--gen java:java5), generated code uses "Arrays.copyOf", which is only available in Java 1.6+.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)