[GitHub] [trafficserver] pbchou commented on issue #8728: Lua Plugin memory leak on remap configuration reloads.

[GitBox <gi...@apache.org>]

pbchou commented on issue #8728:
URL: https://github.com/apache/trafficserver/issues/8728#issuecomment-1068573969


   I can't really tell except with the global and file-local variables since I am testing with 100MB chunks. There might be leakages of other things, but they are too small to register with only the small test script. You would probably have to run with tcmalloc or jemalloc with leak checking turned on to find any other small leaks.
   
   Couple of notes --
   
   1. For 9.1.1 we also cherry-picked the following #8589 (memory leak) and #8080 (core dump) at the recommendations of the community. 
   
   2. It seems that I had to reverse the following commits 36a8cd (which removed the calling the LuaJIT garbage collector when deleting remap instances) and 1f645a (which removed the freeing of the remap instance handle and the clearing of the global registry in the Lua states when deleting remap instances) to get the global and file-local variables to be cleared on reloads. I don't think reversing either one on its own will do it. I think the clearing of the registry and calling the garbage collector are probably more important than the leaking of the instance handle structure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org