[GitHub] [incubator-druid] jihoonson commented on issue #7998: Binary license management system

[GitBox <gi...@apache.org>]

jihoonson commented on issue #7998: Binary license management system
URL: https://github.com/apache/incubator-druid/pull/7998#issuecomment-507478152
 
 
   @Fokko thanks for taking a look!
   
   > Maybe it is a good idea to add the lines on how to run the checker to the `CONTRIBUTING.md` file for further reference.
   
   It sounds good. I think it would be nicer if we add that to our PullRequest template as well.
   
   > One final note on the `findbugs` dependency. I'm looking for replacing this one with spotbugs: https://mvnrepository.com/artifact/com.github.spotbugs/spotbugs-annotations/3.1.12
   But it looks like this one has the same issue with the wrong license. They are working on removing the JSR305 component: spotbugs/spotbugs#421 but this will be tricky as we might expect.
   
   What do you mean by "wrong license"? Spotbugs is also licensed under LGPL, so we shouldn't include it in our binary distribution unless the part you want to use it is particularly licensed under a compatible license.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org