You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/10/23 22:05:05 UTC
Review Request 39610: GEODE-77: fixing a split-brain detected in
integration testing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39610/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and Lynn Gallinat.
Repository: geode
Description
-------
During integration testing I found that GMSJoinLeave was allowing a member to create its own "split-brain" distributed system if it timed out trying to join and network-partition-detection was not enabled.
We now persist in trying to join with the coordinator returned by locators if the locators are part of the distributed system (as opposed to a locator that is booting up and hasn't finished joining).
Another small change: GMSHealthMonitor needs to send suspect messages when it is "playing dead". This is what sick processes often do and we need to be able to handle it.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java ed9f2147c6ce3b3c1c5ace58773007c5958ccfe1
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java 5f9576bdda9c117aec0738ae783b5542d069ba26
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 57611e67614aed814834889347b073d7f04bd014
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java adb49b9e3d40d301bb3dab1172a11a7a3b9e0eda
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 2e903f763f4476d55351623bd86c01f7119a458b
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java 42594cf5b32bf2613170bd01f3cea91e4649b41a
Diff: https://reviews.apache.org/r/39610/diff/
Testing
-------
unit tests, integration testing
Thanks,
Bruce Schuchardt