You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/25 01:43:33 UTC

Review Request 17344: Simplified coordinator election semantics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17344/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0 

Diff: https://reviews.apache.org/r/17344/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 17344: Simplified coordinator election semantics.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17344/#review32838
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17344/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0 
> 
> Diff: https://reviews.apache.org/r/17344/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 17344: Simplified coordinator election semantics.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17344/#review36056
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17344/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0 
> 
> Diff: https://reviews.apache.org/r/17344/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 17344: Simplified coordinator election semantics.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17344/#review36348
-----------------------------------------------------------


Bad patch!

Reviews applied: [17344]

Failed command: git apply --index 17344.patch

Error:
 error: patch failed: src/log/coordinator.cpp:287
error: src/log/coordinator.cpp: patch does not apply


- Mesos ReviewBot


On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17344/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0 
> 
> Diff: https://reviews.apache.org/r/17344/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>