You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "George Jahad (Jira)" <ji...@apache.org> on 2021/07/21 18:13:00 UTC
[jira] [Comment Edited] (HDDS-5328) Improve ozone admin container
delete command error message for later clients
[ https://issues.apache.org/jira/browse/HDDS-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385043#comment-17385043 ]
George Jahad edited comment on HDDS-5328 at 7/21/21, 6:12 PM:
--------------------------------------------------------------
I agree "unknown command type" is confusing. Based on the fact that PR #1845 was closed without merging, I don't think that the Delete Container commend will ever exist.
So I think the correct fix for this case is, as you said, to remove that command. I will change this ticket/PR, to remove the command. Do you agree? Is there someone else I should ask?
In addition, if we do decide to leave it in the cli without adding it to the server, I've found another problem.
I fixed the error message here:
https://github.com/GeorgeJahad/ozone/compare/5e6f6fef96d88a6268df96fffe0c21fc3f59e96e..HDDS-5328-fix-delete-container-error-message
But when I test it, it gets retried 300 times, (i think because of the hadoop rpc retry mechanism). After the retries, it finally gets to my code to print the error, but I doubt users will really wait that long. So if we don't want to remove it, I think we may need to fix the retries as well.
was (Author: georgejahad):
I agree "unknown command type" is confusing. Based on the fact that PR #1845 was closed without merging, I don't think that the Delete Container commend will ever exist, and the correct fix for this case is, as you said, to remove that command. I will change this ticket/PR, to remove the command. Do you agree? Is there someone else I should ask?
In addition, if we do decide to leave it in the cli without adding it to the server, I've found another problem.
I fixed the error message here:
https://github.com/GeorgeJahad/ozone/tree/HDDS-5328-fix-delete-container-error-message
But when I test it, it gets retried 300 times, (i think because of the hadoop rpc retry mechanism). After the retries, it finally gets to my code to print the error, but I doubt users will really wait that long. So if we don't want to remove it, I think we may need to fix the retries as well.
> Improve ozone admin container delete command error message for later clients
> ----------------------------------------------------------------------------
>
> Key: HDDS-5328
> URL: https://issues.apache.org/jira/browse/HDDS-5328
> Project: Apache Ozone
> Issue Type: Task
> Components: Ozone CLI
> Reporter: Siyao Meng
> Assignee: George Jahad
> Priority: Major
>
> Discussion: https://github.com/apache/ozone/pull/1845#issuecomment-770831581
> Keep the command, but should improve the error message to make users feel less like this is a bug by printing sth like: "This command is only available to Ozone SCM version <= X.X. See <link to jira page> for more details."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org