[GitHub] [lucene-solr] dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

[GitBox <gi...@apache.org>]

dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-568654612
 
 
   I think one of the most important next steps for Solr is that it support the vast majority of plugin abstractions, and that is the goal of this PR.  For example the schema's abstractions are super important.  I don't know what it takes for a plugin abstraction to support hot-loading; I deliberately overlooked that.  Can they both be done easily at the same time?  If not I suggest a separating that out.
   
   I know there is no test here yet.  I had something very WIP I didn't commit but proved very useful in trying out the schema.  I had it in `TestPackages`; does that seem suitable?  I wonder if we should have a test configSet in which _every_ plugin specification point is in its own package as a way of testing total coverage.  WDYT?
   
   One thing *not* working that is important is lifecycle methods like `SolrCoreAware`; maybe others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org