You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/09 07:17:29 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #40326: [SPARK-42708] [Docs] Improve doc about protobuf java file can't be indexed.

LuciferYang commented on code in PR #40326:
URL: https://github.com/apache/spark/pull/40326#discussion_r1130573900


##########
connector/protobuf/README.md:
##########
@@ -34,3 +34,17 @@ export SPARK_PROTOC_EXEC_PATH=/path-to-protoc-exe
 
 The user-defined `protoc` binary files can be produced in the user's compilation environment by source code compilation, 
 for compilation steps, please refer to [protobuf](https://github.com/protocolbuffers/protobuf).
+
+### Work with IDE

Review Comment:
   1. I'm not sure whether this item should be added. 
   2. On the other hand, there are many modules that use protobuf, such as `core` (in fact, the `StoreTypes `generated in the `core` module have exceeded the default limit of IntelliJ),  `connect-common`, so if we need to add this one, should put it in a more general place instead of in `protobuf` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org