[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables
URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302629209
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/Closeables.java
 ##########
 @@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Arrays;
+
+
+public class Closeables {
+
+  public static void close(Iterable<? extends Closeable> ac)
+      throws IOException {
+
+    if (ac == null) {
+      return;
+    } else if (ac instanceof Closeable) {
+      ((Closeable) ac).close();
+      return;
+    }
+
+    IOException topLevelException = null;
+
+    for (Closeable closeable : ac) {
+      try {
+        if (closeable != null) {
+          closeable.close();
+        }
+      } catch (IOException e) {
+        if (topLevelException == null) {
+          topLevelException = e;
+        } else if (e != topLevelException) {
+          topLevelException.addSuppressed(e);
+        }
+      }
+    }
+
+    if (topLevelException != null) {
+      throw topLevelException;
 
 Review comment:
   I like moving methods to common utils like this, except that we just cannot log additional information about the object we are trying to work on (in this case, a Closeable). All we will see in the log is "Failed to close resource" . Hopefully the exception provides more information, but if it is just (say) "No such connection" and does not give any source or destination address/hostname, then we are stuck with an ERROR  log that does not tell us much more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org