[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1567: MINIFICPP-2111 - Remove test-only method

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1567:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1567#discussion_r1182739954


##########
extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:
##########


Review Comment:
   ```
   /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:162:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
       for (auto it : connectionMap) {
                 ^
            const  &
   /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:474:13: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
     for (auto it : connectionMap) {
               ^
          const  &
   /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:762:13: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
     for (auto it : connectionMap) {
               ^
          const  &
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org