You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/15 04:45:04 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4319: Init version of SQLServer visitor
terrymanu opened a new pull request #4319: Init version of SQLServer visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4319
For #4318.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4319:
Init version of SQLServer visitor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4319: Init version of SQLServer visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4319#issuecomment-586554844
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=h1) Report
> Merging [#4319](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/284a27a0f81ba4d57ee4a5e6dc25abd36f486123?src=pr&el=desc) will **decrease** coverage by `0.67%`.
> The diff coverage is `1.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4319 +/- ##
============================================
- Coverage 57.2% 56.52% -0.68%
Complexity 352 352
============================================
Files 1027 1030 +3
Lines 18160 18383 +223
Branches 3284 3347 +63
============================================
+ Hits 10388 10391 +3
- Misses 7117 7337 +220
Partials 655 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ingsphere/sql/parser/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL1NRTFNlcnZlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...l/parser/core/visitor/ParseTreeVisitorFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvUGFyc2VUcmVlVmlzaXRvckZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/sql/parser/visitor/impl/SQLServerDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRENMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...hardingsphere/sql/parser/SQLServerParserEntry.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9TUUxTZXJ2ZXJQYXJzZXJFbnRyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyVENMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...phere/sql/parser/core/extractor/util/RuleName.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci91dGlsL1J1bGVOYW1lLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=footer). Last update [284a27a...6e95d12](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4319?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4319: Init
version of SQLServer visitor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4319: Init version of SQLServer visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4319#issuecomment-586555015
## Pull Request Test Coverage Report for [Build 9559](https://coveralls.io/builds/28748877)
* **3** of **225** **(1.33%)** changed or added relevant lines in **6** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.7%**) to **60.143%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/28748877/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L55) | 0 | 2 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28748877/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L37) | 0 | 6 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/SQLServerParserEntry.java](https://coveralls.io/builds/28748877/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQLServerParserEntry.java#L56) | 0 | 9 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDCLVisitor.java](https://coveralls.io/builds/28748877/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDCLVisitor.java#L56) | 0 | 36 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java](https://coveralls.io/builds/28748877/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQLServerVisitor.java#L105) | 0 | 169 | 0.0%
<!-- | **Total:** | **3** | **225** | **1.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28748877/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L118) | 1 | 61.11% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28748877/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **4** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28748877/badge)](https://coveralls.io/builds/28748877) |
| :-- | --: |
| Change from base [Build 860](https://coveralls.io/builds/28737797): | -0.7% |
| Covered Lines: | 11056 |
| Relevant Lines: | 18383 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4319:
Init version of SQLServer visitor
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4319: Init version of SQLServer visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services