You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by vitogav <gi...@git.apache.org> on 2015/08/18 23:21:51 UTC
[GitHub] incubator-geode pull request: Fix for GEODE-222
GitHub user vitogav opened a pull request:
https://github.com/apache/incubator-geode/pull/17
Fix for GEODE-222
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vitogav/incubator-geode Fix/GEODE-222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 7b822925f34cb7d72fcd96c9efa93135b5febfe9
Author: Vito Gavrilov <vg...@pivotal.io>
Date: 2015-08-18T01:30:12Z
Handle region create/destroy remote event in Redis adpater
Ignore events where region creation initiated remotely attempts to create a local region reference when the region has already been destroyed. Also, the destruction of a region may be caught the query engine, so I have accounted for that by handling com.gemstone.gemfire.cache.query.RegionNotFoundException. Finally, a the Jedis client timeout has been increased for RedisDistDunitTest to account for concurrent region creation/destruction and an expected exception has been added to not fail over the log scanning. Sometimes when a region is destroyed the PooledMessage Processor will log a regiondestroyed exception, which is ok, but makes the test fail.
commit 95c2712a5892872df526e55b08cf32daed447261
Author: Vito Gavrilov <vg...@pivotal.io>
Date: 2015-08-18T21:07:50Z
[GEODE-222] Use stable region entry snapshots in redis adapter
Although I was not able to reproduce this bug, this is most likely the fix. The encoder was given Entry objects provided by Region#entrySet which can throw EntryDestroyedExceptions if an entry becomes stale, and since the encoder was returning null upon an exception instead of letting the caller handle it, the bug only became evident when trying to hand off a null response to netty. The fix is to not catch exceptions during any encoding and to provide stable entry objects to the coder.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: Fix for GEODE-222
Posted by vitogav <gi...@git.apache.org>.
Github user vitogav commented on the pull request:
https://github.com/apache/incubator-geode/pull/17#issuecomment-135513863
Will open different pull request fixing GEODE 222 a different way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: Fix for GEODE-222
Posted by vitogav <gi...@git.apache.org>.
Github user vitogav closed the pull request at:
https://github.com/apache/incubator-geode/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---