You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/27 02:27:17 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1921: fix: regex & omit vars when no value

liuxiran commented on a change in pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#discussion_r640244030



##########
File path: web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##########
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
     cy.contains('Confirm').click();
 
     cy.contains('Next').click();
-    cy.get(selector.nodes_0_host).type(data.host2);
+    cy.get(selector.nodes_0_host).type('@');

Review comment:
       It would be better to define a data param




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org