You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (JIRA)" <ji...@apache.org> on 2019/07/09 16:11:00 UTC
[jira] [Comment Edited] (CASSANDRA-15203) Fix AlterTableStatement
dropped type validation order
[ https://issues.apache.org/jira/browse/CASSANDRA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881344#comment-16881344 ]
Aleksey Yeschenko edited comment on CASSANDRA-15203 at 7/9/19 4:10 PM:
-----------------------------------------------------------------------
Branch [here|https://github.com/iamaleksey/cassandra/commits/15203-4.0], [CI|https://circleci.com/workflow-run/ace8a7c2-7993-406c-9b3e-0b5d53e2323c].
was (Author: iamaleksey):
Branch [here|https://github.com/iamaleksey/cassandra/commits/15203-4.0]
> Fix AlterTableStatement dropped type validation order
> -----------------------------------------------------
>
> Key: CASSANDRA-15203
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15203
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Normal
> Fix For: 4.0
>
>
> 4.0 has a minor bug in AlterTableStatement, in which we compare value compatibility of dropped type with new type instead of the other way around (and order is significant here).
> This results in more conversions identified as valid than should be allowed to.
> The fix is a trivial one-liner.
> Relatedly, we should audit all implementations of {{isValueCompatible()}} out there - at least one, {{BytesType}} - is no longer valid in 3.0+, since {{BytesType}} can no longer correctly read any complex column. And perhaps go even further, and restrict column recreation to only previously dropped type *precisely*, for which I have a couple arguments as well.
> That said, I'd like to defer those to a different ticket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org