[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

[britter <gi...@git.apache.org>]

Github user britter commented on the issue:

    https://github.com/apache/maven-surefire/pull/135
  
    @Tibor17: answering your comment from #133:
    
    > In reality the user would use only one dependency and not the profiles. WDYT ?
    
    Yes, this is just for testing purposes, so that we can test JUnit 4 & 5 side by side.
    
    > Do you think it may happen that some user would like to use both dependencies Jupiter and Vintage and so that the plugin would have to be configured in POM and filter dependencies?
    
    I think that is a very likely use case. This of a project slowly migrating to JUnit 5. They may want to keep their old JUnit 4 tests and start writing JUnit 5 tests.
    
    I think the provider lookup in AbstractSurefireMojo should be smart enough to know which JUnit engines it needs to configure. For example:
    - if only org.junit.Test annotation is in classapth -> run with JUnit 4.12
    - if only org.junit.api.jupiter.Test annotation is in classpath -> run with JUnit jupiter engine
    - if both annotations are in classpath -> run with JUnit jupier and JUnit vintage engine
    
    WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org