[PATCH] [EMAIL] Checkstyle errors cleaned up

[Eric Spiegelberg <li...@spiegs.com>]

I read on the user list that Commons Email is approaching a v1.0 release 
and decided to take a look at the Maven reports to see how close it was 
and what needed to be done. I'm always somewhat disappointed when the 
reports reflect that things aren't as tight as I've come to expect from 
Jakarta software. Instead of groaning, I decided to do the clean up 
myself. I am submitting a patch that fixes 184 of the192 Checkstyle 
errors in Commons Email.

The patch includes trivial refactoring to use the Map interface instead 
of Hashtable. Other things such as cleaning up or adding missing 
javadoc, cleaning indentation, curly braces, parenthesis, and removing 
tabs and trailing spaces at the end of lines. The 8 remaining errors 
indicate that the file does not end with a newline, which they do. I 
assume this is an error with the Maven-Checkstyle plugin.

It's not glamorous and it's not going to set anyone's world on fire, but 
I felt it would be nice to have a clean Checkstyle report for a v1.0 
release. This is my first submission to Jakarta and I welcome any 
feedback in order to make this patch accepted smoothly.

Thanks,
Eric Spiegelberg

Re: [PATCH] [EMAIL] Checkstyle errors cleaned up

[Corey Scott <co...@gmail.com>]

Eric,

Firstly, welcome... Secondly... thanks.

There are two things that would like to suggest with your patch.

First:
Please try to break this patch down into discrete sections.  i.e. one
patch for formatting and one for each of the other changes.

Second:
Please submit your patch(es) to the bugzilla as files.  This allows
use to keep everything in one place.

Again, welcome and thanks.
Corey

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org