[GitHub] [incubator-mxnet] aaronmarkham commented on issue #16787: [CD] PyPI pipeline fix

[GitBox <gi...@apache.org>]

aaronmarkham commented on issue #16787: [CD] PyPI pipeline fix
URL: https://github.com/apache/incubator-mxnet/pull/16787#issuecomment-554060125
 
 
   > @aaronmarkham @lanking520 @larroy make sure your approvals are better informed next time.
   
   My bad. I agree that I'm not fully informed on every aspect of creating packages, and took it for granted the the OP was informed due to the apparent successful tests. I'll give him much latitude and trust, and even risk not having to nanny the PR by running the tests myself. But, I think you're conflating issues. The publish process was tested by the OP, and the change aligns with my understanding of our common longer term goals. Changes that impacted Python 2 support in an unrelated PR were not in scope in the review this particular PR. Nonetheless, I appreciate that you took the time to also review this PR as you're most knowledgable about creating the pip packages.
   
   Let's clarify what's going on here please.
   
   If the pipeline is to make artifacts, why can't it do that using Python3 only? Can it not suffice for any artifact building of the packages, or must we build the Python 2 packages with all Python 2 tooling?  
   
   We have other situations where we build artifacts in one realm, and I have been using every opportunity to add Python3 capability, and for new stuff, default to Python3. If this is not the case, it should be brought up on dev@ as it's a bit of a philosophical switch. Plus, if I plan to contribute a tutorial or example or CI tooling, as long as it doesn't break something else, I'm in no obligation to make it Python 2 compatible, am I?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services