You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/29 14:33:49 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #915: fix: health check
AlexStocks commented on a change in pull request #915:
URL: https://github.com/apache/dubbo-go/pull/915#discussion_r549726231
##########
File path: protocol/rpc_status.go
##########
@@ -30,12 +30,17 @@ import (
)
var (
- methodStatistics sync.Map // url -> { methodName : RPCStatus}
- serviceStatistic sync.Map // url -> RPCStatus
- invokerBlackList sync.Map // store unhealthy url blackList
- blackListRefreshing int32 // store if the refresing method is processing
+ methodStatistics sync.Map // url -> { methodName : RPCStatus}
+ serviceStatistic sync.Map // url -> RPCStatus
+ invokerBlackList sync.Map // store unhealthy url blackList
+ blackListCacheDirty atomic.Value // store if the cache in chain is not refreshed by blacklist
Review comment:
pls using uber atomic package instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org