You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Aireed (via GitHub)" <gi...@apache.org> on 2023/04/06 03:10:50 UTC

[GitHub] [iceberg] Aireed opened a new issue, #7285: should we throw the exception when we have no privilege to access the directory in findVersion method

Aireed opened a new issue, #7285:
URL: https://github.com/apache/iceberg/issues/7285

   HadoopTableOperations#refresh call findVersion() to get the version of metadata.
   When we have no privilege to access the directory , the findVersion returns 0 and  the  refresh method return null with information lost.
   
   i think we should catch the exception and throw it to the caller.
   
   ![image](https://user-images.githubusercontent.com/8862395/230262692-b7c8e215-e0e0-4d8e-b870-6bc094f2de12.png)
   
   
   
   https://github.com/apache/iceberg/blob/7c61537194f9ab68e3d83a16b339ec47180f5f10/core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java#L313
   
   > `int findVersion() {
       Path versionHintFile = versionHintFile();
       FileSystem fs = getFileSystem(versionHintFile, conf);
       try (InputStreamReader fsr =
               new InputStreamReader(**fs.open(versionHintFile)**, StandardCharsets.UTF_8);
           BufferedReader in = new BufferedReader(fsr)) {
         return Integer.parseInt(in.readLine().replace("\n", ""));
       } catch (Exception e) {


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] should we throw the exception when we have no privilege to access the directory in findVersion method [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7285:
URL: https://github.com/apache/iceberg/issues/7285#issuecomment-1745918500

   This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Aireed commented on issue #7285: should we throw the exception when we have no privilege to access the directory in findVersion method

Posted by "Aireed (via GitHub)" <gi...@apache.org>.
Aireed commented on issue #7285:
URL: https://github.com/apache/iceberg/issues/7285#issuecomment-1498437546

   @pvary  ptal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] should we throw the exception when we have no privilege to access the directory in findVersion method [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7285: should we throw the exception when we have no privilege to access the directory in findVersion method
URL: https://github.com/apache/iceberg/issues/7285


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] should we throw the exception when we have no privilege to access the directory in findVersion method [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7285:
URL: https://github.com/apache/iceberg/issues/7285#issuecomment-1767384651

   This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org