You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "SCHJonathan (via GitHub)" <gi...@apache.org> on 2025/10/03 18:21:06 UTC
[PR] done [spark]
SCHJonathan opened a new pull request, #52514:
URL: https://github.com/apache/spark/pull/52514
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Adding `google.protobuf.Any extension = 999;` field to `PipelineCommand`, `DefineDataset`, and `DefineFlow` Protos to support forward-compatibility by carrying additional pipeline command types / dataset or flow's fields that are not yet defined in this version of the proto.
During the planning stage, the Spark Server will resolve and dispatch command / message to the correct handler.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To support forward-compatibility by carrying additional pipeline command types / dataset or flow's fields that are not yet defined in this version of the proto. Useful for internal commands that have not yet open sourced.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Test will be added for feature works using this new field
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "SCHJonathan (via GitHub)" <gi...@apache.org>.
SCHJonathan commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3392078491
> I'm seeing this:
>
> ```
> Generated files for pyspark-connect are out of sync! If you have touched files under sql/connect/common/src/main/protobuf/, please run ./dev/connect-gen-protos.sh. If you haven't touched any file above, please rebase your PR against main branch.
> ```
>
> Did you run gen-connect-protos with an up-to-date Python environment?
My bad, forgot to push the commit. Will let you know once the build is green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3393407137
Merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "SCHJonathan (via GitHub)" <gi...@apache.org>.
SCHJonathan commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3391161905
@sryza when you have time do you wanna take another look at this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza closed pull request #52514: [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility
URL: https://github.com/apache/spark/pull/52514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796] Add `extension` field to pipeline protos to support forward compatibility [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on code in PR #52514:
URL: https://github.com/apache/spark/pull/52514#discussion_r2403001487
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -41,6 +42,12 @@ message PipelineCommand {
DefineFlowQueryFunctionResult define_flow_query_function_result = 8;
}
+ // Reserved field for protocol extensions.
+ // Used to support forward-compatibility by carrying additional command types
+ // that are not yet defined in this version of the proto. During planning, the
+ // engine will resolve and dispatch the concrete command contained in this field.
+ google.protobuf.Any extension = 999;
Review Comment:
Should this be part of the `command_type` `oneof`? Seems like this would be mutually exclusive with the existing set of commands?
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -89,6 +96,12 @@ message PipelineCommand {
// The location in source code that this dataset was defined.
optional SourceCodeLocation source_code_location = 9;
+
+ // Reserved field for protocol extensions.
+ // Used to support forward-compatibility by carrying additional fields
+ // that are not yet defined in this version of the proto. During planning, the
+ // engine will resolve and dispatch the concrete command contained in this field.
+ google.protobuf.Any extension = 999;
Review Comment:
It looks like best practice is to use `repeated` for extensions that aren't part of a `oneof`: https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/base.proto#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3391320443
Thanks for rebasing – will merge once build is green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3392059732
I'm seeing this:
```
Generated files for pyspark-connect are out of sync! If you have touched files under sql/connect/common/src/main/protobuf/, please run ./dev/connect-gen-protos.sh. If you haven't touched any file above, please rebase your PR against main branch.
```
Did you run gen-connect-protos with an up-to-date Python environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "AnishMahto (via GitHub)" <gi...@apache.org>.
AnishMahto commented on code in PR #52514:
URL: https://github.com/apache/spark/pull/52514#discussion_r2417996244
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -235,6 +241,12 @@ message SourceCodeLocation {
optional string file_name = 1;
// The specific line number that this pipeline source code is located at, if applicable.
optional int32 line_number = 2;
+
+ // Reserved field for protocol extensions.
+ // Used to support forward-compatibility by carrying additional fields
+ // that are not yet defined in this version of the proto. During planning, the
+ // engine will resolve and dispatch the concrete command contained in this field.
+ repeated google.protobuf.Any extension = 999;
Review Comment:
Is this intentionally repeated, and if so why?
Edit: Nevermind, just saw above discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796] Add `extension` field to pipeline protos to support forward compatibility [spark]
Posted by "SCHJonathan (via GitHub)" <gi...@apache.org>.
SCHJonathan commented on PR #52514:
URL: https://github.com/apache/spark/pull/52514#issuecomment-3372390647
Hi @vicennial @hvanhovell, wondering whether yall wanna take a look at this PR. This PR is adding extension field to the DefineDataset and DefineFlow proto to support databricks only field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53796][SDP] Add `extension` field to a few pipeline protos to support forward compatibility [spark]
Posted by "AnishMahto (via GitHub)" <gi...@apache.org>.
AnishMahto commented on code in PR #52514:
URL: https://github.com/apache/spark/pull/52514#discussion_r2417996244
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -235,6 +241,12 @@ message SourceCodeLocation {
optional string file_name = 1;
// The specific line number that this pipeline source code is located at, if applicable.
optional int32 line_number = 2;
+
+ // Reserved field for protocol extensions.
+ // Used to support forward-compatibility by carrying additional fields
+ // that are not yet defined in this version of the proto. During planning, the
+ // engine will resolve and dispatch the concrete command contained in this field.
+ repeated google.protobuf.Any extension = 999;
Review Comment:
Is this intentionally repeated, and if so why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org