You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Mairbek Khadikov (JIRA)" <ji...@apache.org> on 2012/08/18 01:38:37 UTC
[jira] [Created] (PIG-2882) Use Deque instead of Stack
Mairbek Khadikov created PIG-2882:
-------------------------------------
Summary: Use Deque instead of Stack
Key: PIG-2882
URL: https://issues.apache.org/jira/browse/PIG-2882
Project: Pig
Issue Type: Improvement
Components: impl
Affects Versions: 0.10.0
Reporter: Mairbek Khadikov
Priority: Trivial
There are places where java.util.Stack is used.
Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
Quote from the java.util.Deque javadoc:
>Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIG-2882) Use Deque instead of Stack
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy reassigned PIG-2882:
--------------------------------------
Assignee: Mairbek Khadikov
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Assignee: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Status: Patch Available (was: Open)
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: patch
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Status: Patch Available (was: Open)
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Attachment: Deque.patch
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2882:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.11
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Mairbek!
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Assignee: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Fix For: 0.11
>
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437183#comment-13437183 ]
Mairbek Khadikov commented on PIG-2882:
---------------------------------------
Fixed test and updated the patch file
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Attachment: (was: Deque.patch)
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Status: Open (was: Patch Available)
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: patch
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2882) Use Deque instead of Stack
Posted by "Mairbek Khadikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mairbek Khadikov updated PIG-2882:
----------------------------------
Attachment: Deque.patch
> Use Deque instead of Stack
> --------------------------
>
> Key: PIG-2882
> URL: https://issues.apache.org/jira/browse/PIG-2882
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.10.0
> Reporter: Mairbek Khadikov
> Priority: Trivial
> Labels: newbie, patch
> Attachments: Deque.patch
>
>
> There are places where java.util.Stack is used.
> Replace it with java.util.Deque because it java.util.Stack is a legacy class and extends java.util.Vector which is synchronized and slow.
> Quote from the java.util.Deque javadoc:
> >Deques can also be used as LIFO (Last-In-First-Out) stacks. This interface should be used in preference to the legacy Stack class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira