[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request #4494: Akka http server responds HEAD request as GET

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4494: Akka http server responds HEAD request as GET
URL: https://github.com/apache/incubator-openwhisk/pull/4494#discussion_r297305724
 
 

 ##########
 File path: tests/src/test/scala/org/apache/openwhisk/core/cli/test/WskWebActionsTests.scala
 ##########
 @@ -305,6 +305,34 @@ class WskWebActionsTests extends TestHelpers with WskTestHelpers with RestUtil w
       response.body.asByteArray shouldBe Base64.getDecoder().decode(png)
   }
 
+  /**
+   * Tests web action for HEAD requests
+   */
+  it should "create a web action making a HEAD request" in withAssetCleaner(wskprops) { (wp, assetHelper) =>
+    val name = "webaction"
+    val file = Some(TestUtils.getTestActionFilename("echo.js"))
+    val host = getServiceURL()
+    val url = s"$host$testRoutePath/$namespace/default/$name.text/__ow_user"
 
 Review comment:
   you should not need this here for a HEAD test: `.text/__ow_user` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services