[GitHub] [incubator-pegasus] WHBANG commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI

[GitBox <gi...@apache.org>]

WHBANG commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885258069


##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
         <version>0.13</version>
       </plugin>
 
-      <plugin>
-        <groupId>com.diffplug.spotless</groupId>
-        <artifactId>spotless-maven-plugin</artifactId>
-        <version>2.12.2</version>
-        <configuration>
-          <formats>
-            <format>
-              <includes>
-                <include>*.md</include>
-                <include>.gitignore</include>
-              </includes>
-              <trimTrailingWhitespace/>
-              <endWithNewline/>
-              <indent>
-                <tabs>true</tabs>
-                <spacesPerTab>4</spacesPerTab>
-              </indent>
-            </format>
-          </formats>
-          <java>
-            <excludes>
-              <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
-              <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
-            </excludes>
-            <googleJavaFormat>
-              <version>1.7</version>
-              <style>GOOGLE</style>
-            </googleJavaFormat>
-          </java>
-        </configuration>
-        <executions>
-          <execution>
-            <goals>
-              <goal>check</goal>
-            </goals>
-            <phase>compile</phase>
-          </execution>
-        </executions>
-      </plugin>

Review Comment:
   1.  code style check these don't feel good to write in our logic code
   2.  we can configure code format plugin in ieda



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org