[GitHub] [incubator-kyuubi] wForget commented on pull request #3216: [KYUUBI #3214] Plan only mode should unset when mode value is incorrect

[GitBox <gi...@apache.org>]

wForget commented on PR #3216:
URL: https://github.com/apache/incubator-kyuubi/pull/3216#issuecomment-1211461663

   unset conf doesn't seem to be a good way:
   ```
   set kyuubi.operation.plan.only.mode=parser; // success
   select 1; // exception
   select 1; // success without plan mode
   ```
   
   we can add `UNKNOWN` type to `OperationModes` and throw an exception in `PlanOnlyStatement#runInternal`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org