You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/10 17:10:46 UTC
[kudu-CR] [thirdparty] stip more features from libcurl
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15195
Change subject: [thirdparty] stip more features from libcurl
......................................................................
[thirdparty] stip more features from libcurl
It turned out that current configuration of libcurl in thirdparty
picks up IDN2 (support for international domain names) and extra
verification of cookies using PSL (Public Domain List) library,
if corresponding libraries are available on the build machine.
There aren't any known built-time or run-time use cases for these
features at this point, so it makes sense to remove them.
Explicitly configuring libcurl without these features helps to get
rid of linkage errors on macOS in case of RELEASE builds if
corresponding libraries are present:
Undefined symbols for architecture x86_64:
"_idn2_check_version", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
_curl_version in libcurl.a(libcurl_la-version.o)
_curl_version_info in libcurl.a(libcurl_la-version.o)
"_idn2_free", referenced from:
_conn_free in libcurl.a(libcurl_la-url.o)
_create_conn in libcurl.a(libcurl_la-url.o)
"_idn2_lookup_ul", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
"_idn2_strerror", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
"_psl_builtin", referenced from:
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
"_psl_free", referenced from:
_Curl_psl_destroy in libcurl.a(libcurl_la-psl.o)
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
"_psl_get_version", referenced from:
_curl_version in libcurl.a(libcurl_la-version.o)
"_psl_is_cookie_domain_acceptable", referenced from:
_Curl_cookie_add in libcurl.a(libcurl_la-cookie.o)
"_psl_latest", referenced from:
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
ld: symbol(s) not found for architecture x86_64
Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/15195/1
--
To view, visit http://gerrit.cloudera.org:8080/15195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] stip more features from libcurl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15195 )
Change subject: [thirdparty] stip more features from libcurl
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 17:52:34 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] stip more features from libcurl
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15195 )
Change subject: [thirdparty] stip more features from libcurl
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15195/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15195/2//COMMIT_MSG@7
PS2, Line 7: stip
Typo: strip
--
To view, visit http://gerrit.cloudera.org:8080/15195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 21:10:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] stip more features from libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15195 )
Change subject: [thirdparty] stip more features from libcurl
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15195/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15195/2//COMMIT_MSG@7
PS2, Line 7: stip
> Typo: strip
Thank you for the feedback! I've submitted the patch with the typo already.
--
To view, visit http://gerrit.cloudera.org:8080/15195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 21:27:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] stip more features from libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15195 )
Change subject: [thirdparty] stip more features from libcurl
......................................................................
[thirdparty] stip more features from libcurl
It turned out that current configuration of libcurl in thirdparty
picks up IDN2 (support for international domain names) and extra
verification of cookies using PSL (Public Domain List) library,
if corresponding libraries are available on the build machine.
There aren't any known built-time or run-time use cases for these
features at this point, so it makes sense to remove them.
Explicitly configuring libcurl without these features helps to get
rid of linkage errors on macOS in case of RELEASE builds if
corresponding libraries are present:
Undefined symbols for architecture x86_64:
"_idn2_check_version", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
_curl_version in libcurl.a(libcurl_la-version.o)
_curl_version_info in libcurl.a(libcurl_la-version.o)
"_idn2_free", referenced from:
_conn_free in libcurl.a(libcurl_la-url.o)
_create_conn in libcurl.a(libcurl_la-url.o)
"_idn2_lookup_ul", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
"_idn2_strerror", referenced from:
_idnconvert_hostname in libcurl.a(libcurl_la-url.o)
"_psl_builtin", referenced from:
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
"_psl_free", referenced from:
_Curl_psl_destroy in libcurl.a(libcurl_la-psl.o)
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
"_psl_get_version", referenced from:
_curl_version in libcurl.a(libcurl_la-version.o)
"_psl_is_cookie_domain_acceptable", referenced from:
_Curl_cookie_add in libcurl.a(libcurl_la-cookie.o)
"_psl_latest", referenced from:
_Curl_psl_use in libcurl.a(libcurl_la-psl.o)
ld: symbol(s) not found for architecture x86_64
Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Reviewed-on: http://gerrit.cloudera.org:8080/15195
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)