You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sunkai-cai (via GitHub)" <gi...@apache.org> on 2023/03/08 08:27:33 UTC
[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #24501: Support unix domain socket
sunkai-cai opened a new pull request, #24501:
URL: https://github.com/apache/shardingsphere/pull/24501
Fixes #24095.
ShardingSphere-Proxy supported UDS。
Changes proposed in this pull request:
- In ShardingSphere-Proxy，add supported UDS by the `socket path` paramet.
- In start.sh，add `-s` of paramet to setting `socket path`.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai commented on pull request #24501: Support unix domain socket
Posted by "sunkai-cai (via GitHub)" <gi...@apache.org>.
sunkai-cai commented on PR #24501:
URL: https://github.com/apache/shardingsphere/pull/24501#issuecomment-1459909288
Still need to improve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai closed pull request #24501: Support unix domain socket
Posted by "sunkai-cai (via GitHub)" <gi...@apache.org>.
sunkai-cai closed pull request #24501: Support unix domain socket
URL: https://github.com/apache/shardingsphere/pull/24501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24501: Support unix domain socket
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24501:
URL: https://github.com/apache/shardingsphere/pull/24501#issuecomment-1459786632
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24501](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dea70c0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5fec520bb9884e6c81da67f9943e3f7828a76a97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fec520) will **increase** coverage by `0.16%`.
> The diff coverage is `41.66%`.
> :exclamation: Current head dea70c0 differs from pull request most recent head be025ba. Consider uploading reports for the commit be025ba to get more accurate results
```diff
@@ Coverage Diff @@
## master #24501 +/- ##
============================================
+ Coverage 50.05% 50.22% +0.16%
- Complexity 1584 1589 +5
============================================
Files 3237 3274 +37
Lines 53392 53759 +367
Branches 9847 9889 +42
============================================
+ Hits 26724 26998 +274
- Misses 24290 24349 +59
- Partials 2378 2412 +34
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ingsphere/agent/plugin/tracing/AgentExtension.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3Rlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL0FnZW50RXh0ZW5zaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `5.15% <0.00%> (-0.34%)` | :arrow_down: |
| [...atement/ral/queryable/ExportMetaDataStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9yYWwvcXVlcnlhYmxlL0V4cG9ydE1ldGFEYXRhU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ent/ral/queryable/ExportStorageNodesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9yYWwvcXVlcnlhYmxlL0V4cG9ydFN0b3JhZ2VOb2Rlc1N0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...atement/ral/updatable/ImportMetaDataStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9yYWwvdXBkYXRhYmxlL0ltcG9ydE1ldGFEYXRhU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/advice/proxy/CommitTransactionsCountAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9tZXRyaWNzL2NvcmUvYWR2aWNlL3Byb3h5L0NvbW1pdFRyYW5zYWN0aW9uc0NvdW50QWR2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../advice/proxy/RollbackTransactionsCountAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9tZXRyaWNzL2NvcmUvYWR2aWNlL3Byb3h5L1JvbGxiYWNrVHJhbnNhY3Rpb25zQ291bnRBZHZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...s/core/exporter/impl/proxy/ProxyStateExporter.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9tZXRyaWNzL2NvcmUvZXhwb3J0ZXIvaW1wbC9wcm94eS9Qcm94eVN0YXRlRXhwb3J0ZXIuamF2YQ==) | `83.33% <100.00%> (ø)` | |
| [.../value/string/MySQLVarcharBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxWYXJjaGFyQmlubG9nUHJvdG9jb2xWYWx1ZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...iscovery/rule/DatabaseDiscoveryDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L3J1bGUvRGF0YWJhc2VEaXNjb3ZlcnlEYXRhU291cmNlUnVsZS5qYXZh) | `77.41% <100.00%> (-1.37%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/shardingsphere/pull/24501?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org