[jira] [Commented] (RATIS-247) Add a JUnit RunListener to dump all threads when test timeout

["Elek, Marton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502405#comment-16502405 ] 

Elek, Marton commented on RATIS-247:
------------------------------------

Thanks [~szetszwo] the patch. It looks good and pretty smart for me. Tested with the same method as Mukul, and worked well.

Just a few question:
 # Is there any reason to remove the maven-compiler plugin parameters from pom.xml L707? If it's not used any more, it could be removed together with the profile (there is an empty profile now).
 # I am just curious why do we need for getTimeoutException method. I understand how does it work but not clear why we need it. Can we expect different exceptions in different environments/os? Or is it just to make junit version upgrade more safe?

> Add a JUnit RunListener to dump all threads when test timeout
> -------------------------------------------------------------
>
>                 Key: RATIS-247
>                 URL: https://issues.apache.org/jira/browse/RATIS-247
>             Project: Ratis
>          Issue Type: Test
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: r247_20180525.patch
>
>
> Some unit tests fail with timeout occasionally.  It would be great if it dumps all threads when test timeout.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)