You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2016/01/24 00:54:01 UTC

[GitHub] spark pull request: [SPARK-11574][Core] Add metrics StatsD sink

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/9518#issuecomment-174235341
  
    Hey, so I don't have any major objections to adding this, esp. since this doesn't introduce any new dependencies. As long as you can find a shepherd to review the code, I'm fine pulling this in.
    
    Note that this is going to need to be cleaned up to conform to Spark's code style conventions, esp. the parameter wrapping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org