You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/22 10:33:44 UTC
[jira] [Commented] (FLINK-5865) Throw original exception in states
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877965#comment-15877965 ]
ASF GitHub Bot commented on FLINK-5865:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3380
I think it is a good idea to avoid exception wrapping where ever possible, so +1 to that.
I was wondering if we can improve exception handling even further for the state abstraction, especially getting rid of the `throws Exception` in all the methods on the state interfaces (like `ValueState.get()`).
Can we find some more "specific" exceptions for the signature, like `throws IOException` or `throws StateAccessException`. That would mean that some exceptions would have to be wrapped, though.
I think Java would support exception "downgrading", meaning going to more specific exceptions, without breaking the API.
What do you think?
> Throw original exception in states
> ----------------------------------
>
> Key: FLINK-5865
> URL: https://issues.apache.org/jira/browse/FLINK-5865
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.3.0
> Reporter: Xiaogang Shi
> Assignee: Xiaogang Shi
>
> Now all exception thrown in RocksDB states are converted to {{RuntimeException}}. It's unnecessary and will print useless stacks in the log.
> I think it's better to throw the original exception, without any wrapping.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)