You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (JIRA)" <ji...@apache.org> on 2015/08/10 23:49:46 UTC
[jira] [Commented] (PDFBOX-2423) Page tree handling needs rewriting
[ https://issues.apache.org/jira/browse/PDFBOX-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680828#comment-14680828 ]
Tilman Hausherr commented on PDFBOX-2423:
-----------------------------------------
[~jahewson] Any update on this? Your last change didn't fix all files, but it improved several while not degrading any of the correct files. So I'd suggest:
- you produce a new patch against the current code
- I test it again
- if the patch improves things without worsening anything, then it should be committed.
I am also attaching some new files which worked in rev 1633472 but don't work now. Maybe one of them has an additional clue...
The files are: gs-bugilla691763.pdf, gs-bugzilla688601.pdf, gs-bugzilla689518.pdf, gs-bugzilla693322.pdf, samsung_galaxy_s_4_um-p1.pdf.
> Page tree handling needs rewriting
> ----------------------------------
>
> Key: PDFBOX-2423
> URL: https://issues.apache.org/jira/browse/PDFBOX-2423
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 1.8.7, 2.0.0
> Reporter: John Hewson
> Assignee: John Hewson
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 025957.pdf, 26101_Colors.ai-1.png, 26101_Colors.ai-1.png-diff.png, Basiswissen-Vorschriften.pdf-3.png, Basiswissen-Vorschriften.pdf-3.png-diff.png, Basiswissen-Vorschriften.pdf-4.png, Basiswissen-Vorschriften.pdf-4.png-diff.png, PDFBOX-1058.pdf-1.png, PDFBOX-1058.pdf-1.png-diff.png, PDFBOX-1058.pdf-4.png, PDFBOX-1058.pdf-4.png-diff.png, PDFBOX-1094-tiling_pattern.pdf, PDFBOX-1711-cmyk.pdf-1.png, PDFBOX-1711-cmyk.pdf-1.png-diff.png, PDFBOX-1794-vattenfall.pdf-1.png, PDFBOX-1794-vattenfall.pdf-1.png-diff.png, PDFBOX-1917.pdf-1.png, PDFBOX-1917.pdf-1.png-diff.png, Transparency_group_rewrite3.patch, asy-functionshading.pdf-1.png, asy-functionshading.pdf-1.png-diff.png, bugzilla869140.pdf, example_026.pdf-1.png, gs-bugzilla690467.pdf, gs-bugzilla694385.pdf, jagpdf_doc_patterns.pdf
>
>
> The way in which PDFBox handles the Page tree needs to be rewritten, preferably from scratch. Currently the document catalog returns the raw objects from the page tree, wrapped in either a PDPage or PDPageNode.
> We need to abstract over the page tree and get rid of PDPageNode, we should provide methods which can add/remove PDPage objects *only*. The existing low-level access to the page tree is not needed at the PD-level.
> Inheritance of page properties such as crop box, resources, and rotation should be reimplemented to use whatever new page tree abstraction we invent. We can finally remove the old broken methods which didn't look up the inheritance tree when retrieving these values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org