[GitHub] [mynewt-core] kasjer opened a new pull request #2415: RFC, BSP de-initialization to be executed before boot loader start application

[GitBox <gi...@apache.org>]

kasjer opened a new pull request #2415:
URL: https://github.com/apache/mynewt-core/pull/2415


   This introduces empty hal_bsp_deinit() function
   that is intended to be called by bootloader
   before it calls application reset handler.
   
   mcuboot calls hal_bsp_init() at start it can leave
   various resources initialized before application
   starts.
   In can leave to situation when such resource (timer/uart)
   is configured with interrupt enabled.
   Then in bad case interrupt can be activated before resource
   is reconfigured, or interrupt are remapped but often RAM (bss and data)
   are already wiped out and interrupt (with handler still from
   bootloader will try to execute with its data structures corrupted.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on pull request #2415: BSP de-initialization to be executed before boot loader start application

[GitBox <gi...@apache.org>]

kasjer commented on pull request #2415:
URL: https://github.com/apache/mynewt-core/pull/2415#issuecomment-732453972


   > I think the idea of hal_bsp_deinit() is a good one. I have not looked at all the registers for the stm32 code you have added. Are these just the reset values of these registers?
   
   Pretty much so.
   For enable registers we have reset value (so for most of them 0 with some exceptions like RAM and FLASH).
   For reset registers, all bits that are available are first set then reset.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2415: BSP de-initialization to be executed before boot loader start application

[GitBox <gi...@apache.org>]

kasjer merged pull request #2415:
URL: https://github.com/apache/mynewt-core/pull/2415


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2415: RFC, BSP de-initialization to be executed before boot loader start application

[GitBox <gi...@apache.org>]

apache-mynewt-bot commented on pull request #2415:
URL: https://github.com/apache/mynewt-core/pull/2415#issuecomment-731646668


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/telee02/src/hal_bsp.c
   <details>
   
   ```diff
   @@ -124,7 +124,8 @@
    }
    
    #if MYNEWT_VAL(LORA_NODE)
   -void lora_bsp_enable_mac_timer(void)
   +void
   +lora_bsp_enable_mac_timer(void)
    {
        /* Turn on the LoRa MAC timer. This function is automatically
         * called by the LoRa stack when exiting low power mode.*/
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org