You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Jonathan Barker (JIRA)" <ji...@apache.org> on 2011/03/23 18:22:05 UTC
[jira] [Created] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
AssetPathConstructorImpl should use BaseURLSource
-------------------------------------------------
Key: TAP5-1483
URL: https://issues.apache.org/jira/browse/TAP5-1483
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.4
Reporter: Jonathan Barker
Priority: Minor
Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
Apart from contributing the BaseURLSource, it is a small change from:
StringBuilder builder = new StringBuilder(request.getContextPath());
to
StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
builder.append(request.getContextPath());
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135882#comment-13135882 ]
Hudson commented on TAP5-1483:
------------------------------
Integrated in tapestry-trunk-freestyle #610 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/610/])
TAP5-1483 Make configuration knob to use of BaseURLSource to build fully qualified Assets URL, defaults to false
mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189123
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/assets/AssetsModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ContextAssetFactoryTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Massimo Lusetti (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti reassigned TAP5-1483:
-------------------------------------
Assignee: Massimo Lusetti
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Massimo Lusetti (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti resolved TAP5-1483.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130775#comment-13130775 ]
Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------
Since this is behavior that most people will not want, I think it will need to be configurable, and default off.
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Massimo Lusetti (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti resolved TAP5-1483.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Jonathan Barker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011040#comment-13011040 ]
Jonathan Barker commented on TAP5-1483:
---------------------------------------
The use case is a Facebook app where any image needs to have an absolute URL. Specifically, this was an app for a profile or page Tab. The img tags generated errors that relative URL's were not allowed here. I am guessing that it has to do with their caching. I also started developing in production mode to avoid a proliferation of images, css and js files in their caches.
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Massimo Lusetti (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti reassigned TAP5-1483:
-------------------------------------
Assignee: Massimo Lusetti
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Jonathan Barker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Barker updated TAP5-1483:
----------------------------------
Attachment: patch.txt
Patch
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Jonathan Barker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Barker updated TAP5-1483:
----------------------------------
Attachment: patch.txt
Patch
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Jonathan Barker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011040#comment-13011040 ]
Jonathan Barker commented on TAP5-1483:
---------------------------------------
The use case is a Facebook app where any image needs to have an absolute URL. Specifically, this was an app for a profile or page Tab. The img tags generated errors that relative URL's were not allowed here. I am guessing that it has to do with their caching. I also started developing in production mode to avoid a proliferation of images, css and js files in their caches.
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011002#comment-13011002 ]
Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------
Just trying to figure out why this is necessary ... whta's your scenario where very URL needs to be fully qualified with hostname? Surely, one would think that getting the page request URLs to be fully qualified, with the asset URLs relative to those page request URLs, should be sufficient?
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011002#comment-13011002 ]
Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------
Just trying to figure out why this is necessary ... whta's your scenario where very URL needs to be fully qualified with hostname? Surely, one would think that getting the page request URLs to be fully qualified, with the asset URLs relative to those page request URLs, should be sufficient?
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130775#comment-13130775 ]
Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------
Since this is behavior that most people will not want, I think it will need to be configurable, and default off.
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Jonathan Barker
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use
BaseURLSource
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135882#comment-13135882 ]
Hudson commented on TAP5-1483:
------------------------------
Integrated in tapestry-trunk-freestyle #610 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/610/])
TAP5-1483 Make configuration knob to use of BaseURLSource to build fully qualified Assets URL, defaults to false
mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189123
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/assets/AssetsModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ContextAssetFactoryTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira