You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/11/06 21:26:45 UTC
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #639:
nimble/ll: Fix extended scanner data fragmentation issues
sjanc commented on a change in pull request #639: nimble/ll: Fix extended scanner data fragmentation issues
URL: https://github.com/apache/mynewt-nimble/pull/639#discussion_r343331530
##########
File path: nimble/controller/src/ble_ll_scan.c
##########
@@ -2647,15 +2648,18 @@ ble_ll_hci_send_ext_adv_report(uint8_t ptype, uint8_t *adva, uint8_t adva_type,
hdr, ev->reports);
if (datalen < 0) {
rc = -1;
- /* If we were in the middle of advertising report, let us send truncated report. */
+
if (aux_data &&
- BLE_LL_AUX_CHECK_FLAG(aux_data, BLE_LL_SENT_EVENT_TO_HOST) &&
- BLE_LL_AUX_CHECK_FLAG(aux_data, BLE_LL_AUX_CHAIN_BIT)) {
- report = ev->reports;
+ (aux_data->flags_ll & BLE_LL_AUX_FLAG_HCI_REPORT_SENT) &&
+ !(aux_data->flags_ll & BLE_LL_AUX_FLAG_HCI_TRUNCATED_SENT)) {
+
+ aux_data->flags_ll |= BLE_LL_AUX_FLAG_SCAN_ERROR;
+ aux_data->flags_ll |= BLE_LL_AUX_FLAG_HCI_REPORT_SENT;
Review comment:
report_sent should already be set here, shoudn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services