You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/25 23:00:43 UTC

[GitHub] rdhabalia commented on a change in pull request #3428: Add support for pluggable jvm-metrics

rdhabalia commented on a change in pull request #3428: Add support for pluggable jvm-metrics
URL: https://github.com/apache/pulsar/pull/3428#discussion_r251163149
 
 

 ##########
 File path: conf/broker.conf
 ##########
 @@ -567,6 +567,9 @@ exposeTopicLevelMetricsInPrometheus=true
 # Enable consumer level metrics. default is false
 exposeConsumerLevelMetricsInPrometheus=false
 
+# Classname of Pluggable JVM GC metrics logger that can log GC specific metrics
+jvmGCMetricsLoggerClassName=java.lang.management.ManagementFactory.JvmG1GCMetricsLogger
 
 Review comment:
   right now, default implementation is G1GC and if we change it then it will be breaking change for users with existing configuration. We had similar discussion on log4j configuration change in past so, we decided to maintain compatibility with previous release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services