You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Chia-Ping Tsai (Jira)" <ji...@apache.org> on 2024/08/06 17:28:00 UTC

[jira] [Resolved] (KAFKA-17222) Remove the subclass of KafkaMetricsGroup

     [ https://issues.apache.org/jira/browse/KAFKA-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chia-Ping Tsai resolved KAFKA-17222.
------------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

> Remove the subclass of KafkaMetricsGroup
> ----------------------------------------
>
>                 Key: KAFKA-17222
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17222
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: bboyleonp
>            Priority: Minor
>             Fix For: 4.0.0
>
>
> There are subclass of KafkaMetricsGroup which have override `metricName` [0][1][2]. They are used to keep metrics compatibility. Now, KafkaMetricsGroup has the new constructor which can define the package and class name, and so we don't need to override the `metricName` anymore.
> [0] https://github.com/apache/kafka/blob/9e06767ffa80b26791c3bff6bc9b10b6612ce7d2/core/src/main/scala/kafka/log/UnifiedLog.scala#L116
> [1] https://github.com/apache/kafka/blob/9e06767ffa80b26791c3bff6bc9b10b6612ce7d2/storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java#L77
> [2] https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaBroker.scala#L109



--
This message was sent by Atlassian Jira
(v8.20.10#820010)