You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Marko Niemi (JIRA)" <ji...@apache.org> on 2009/02/15 18:22:59 UTC
[jira] Created: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Add Ivy Library command adds classpath container even though it already exists
------------------------------------------------------------------------------
Key: IVYDE-164
URL: https://issues.apache.org/jira/browse/IVYDE-164
Project: IvyDE
Issue Type: Bug
Components: classpath container
Affects Versions: 2.0.0.beta1
Reporter: Marko Niemi
Priority: Minor
1. Create ivy.xml file
2. Open popup menu with ivy.xml selected
3. Select Add Ivy Library
-> Ivy classpath is added
2. Open popup menu with ivy.xml selected
3. Select Add Ivy Library
-> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694714#action_12694714 ]
Robert Munteanu commented on IVYDE-164:
---------------------------------------
What about issuing a warning that another classpath container already exists?
This should fix any confusion issues and still allow advanced uses cases.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée resolved IVYDE-164.
-----------------------------------
Resolution: Fixed
Assignee: Nicolas Lalevée
I used it many time, it seems ok. So let's resolve it as fixed.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Assignee: Nicolas Lalevée
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Posted by "Marko Niemi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marko Niemi closed IVYDE-164.
-----------------------------
Resolution: Fixed
With the version from SVN this is no longer reproducible.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Attachments: IvyClasspathUtil.java.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Posted by "Marko Niemi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marko Niemi updated IVYDE-164:
------------------------------
Attachment: IvyClasspathUtil.java.patch
A quick fix that is based on 2nd segment being the ivy classpath identifier.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Attachments: IvyClasspathUtil.java.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Marko Niemi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697960#action_12697960 ]
Marko Niemi commented on IVYDE-164:
-----------------------------------
Yes, it is a normal use case to have multiple ivy classpath containers. With web applications it is necessary to have different directories for runtime, tool and test classpaths. So I would guess that there is no need to create a warning of multiple ivy classpath containers.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée updated IVYDE-164:
----------------------------------
Fix Version/s: 2.0.0.final
Remaining Estimate: (was: 1h)
Original Estimate: (was: 1h)
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705733#action_12705733 ]
Nicolas Lalevée commented on IVYDE-164:
---------------------------------------
I have implemented what I described in my last comment.
I am not very sure about the correctness of the implementation regarding the wizard creation, it doesn't seems to be well supported by the JDT API. Any feedback on this will be appreciated.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Marko Niemi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675432#action_12675432 ]
Marko Niemi commented on IVYDE-164:
-----------------------------------
True, someone might want to have multiple classpath containers with different configurations.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Adam Bryzak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696889#action_12696889 ]
Adam Bryzak commented on IVYDE-164:
-----------------------------------
I use multiple classpath containers for main dependencies and test dependencies so they're visually separated in the package explorer.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (IVYDE-164) Add Ivy Library command adds classpath
container even though it already exists
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée reopened IVYDE-164:
-----------------------------------
Actually I can still do it.
But then I don't know if it is a bug or a feature, should we allow sevral IvyDE classpath container in the same project ?
If we allow different container with different resolved configuration, should we support different container with just a different order of classpath entries ?
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-164) Add Ivy Library command adds
classpath container even though it already exists
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703139#action_12703139 ]
Nicolas Lalevée commented on IVYDE-164:
---------------------------------------
Here is what I am willing to implement unless there are some objections:
* an IvyDE classpath container will be unique by ivy.xml and conf:
** having ivy.xml[*] configured and trying to add ivy.xml[*] will fail
** having ivy.xml[default] configured and trying to add ivy.xml[test] will be sucessfull
** having ivy.xml[*] configured and trying to add ivy.xml[test] will fail
* the "add library" action will not just add a container, it will open the wizard of creation of the container with its fields being already filled. So instead of one click there will be two, but it is less than the 3+ clicks needed by the classical "Add library" workflow.
Note: I didn't include the ivysettings and properties in the "uniqueness" check of the IvyDE classpath container in a project: it seems to me too weird to have the same ivy.xml and same conf used with just some different settings.
> Add Ivy Library command adds classpath container even though it already exists
> ------------------------------------------------------------------------------
>
> Key: IVYDE-164
> URL: https://issues.apache.org/jira/browse/IVYDE-164
> Project: IvyDE
> Issue Type: Bug
> Components: classpath container
> Affects Versions: 2.0.0.beta1
> Reporter: Marko Niemi
> Priority: Minor
> Fix For: 2.0.0.final
>
> Attachments: IvyClasspathUtil.java.patch
>
>
> 1. Create ivy.xml file
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> Ivy classpath is added
> 2. Open popup menu with ivy.xml selected
> 3. Select Add Ivy Library
> -> another Ivy classpath is added
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.