[GitHub] [trafficcontrol] zrhoffman opened a new issue #5758: `go vet`: Assignment copies lock value

[GitBox <gi...@apache.org>]

zrhoffman opened a new issue #5758:
URL: https://github.com/apache/trafficcontrol/issues/5758


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Grove
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   `go vet -copylocks ./...` finds 1 issues:
   
   <table><thead><th>Message</th><th>Line of code</th></thead><tbody>
   
   <tr><td><code>assignment copies lock value to newTransport: net/http.Transport contains sync.Mutex</code></td><td>
   
   https://github.com/apache/trafficcontrol/blob/61e423f33b8f4b61a6228c9e3d0fbac646d231f2/grove/remap/remap.go#L500
   </td></tr>
   </tbody></table>
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   `go vet -copylocks ./...` should find 0 issues.
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   ```shell
   go vet -copylocks ./...
   ```
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c commented on issue #5758: `go vet`: Assignment copies lock value

[GitBox <gi...@apache.org>]

rob05c commented on issue #5758:
URL: https://github.com/apache/trafficcontrol/issues/5758#issuecomment-823309813


   This is not a bug, the copy is necessary. Do not remove the Transport copy.
   
   I don't object to making `go vet` happy. But if someone is "fixing" this, please make sure the entire Transport is still copied. Changing it to not copy the Transport will be a serious and probably subtle bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c closed issue #5758: `go vet`: Assignment copies lock value

[GitBox <gi...@apache.org>]

rob05c closed issue #5758:
URL: https://github.com/apache/trafficcontrol/issues/5758


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org