You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/29 00:29:26 UTC
[GitHub] codecov-io commented on issue #3812: ContainerClient + akka http
alternative to HttpUtils
codecov-io commented on issue #3812: ContainerClient + akka http alternative to HttpUtils
URL: https://github.com/apache/incubator-openwhisk/pull/3812#issuecomment-401212372
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=h1) Report
> Merging [#3812](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/c202ba7e4ce2b593c49161f3ca7ced7668a7397b?src=pr&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `7.4%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3812 +/- ##
==========================================
- Coverage 75.19% 74.85% -0.35%
==========================================
Files 136 137 +1
Lines 6383 6414 +31
Branches 387 393 +6
==========================================
+ Hits 4800 4801 +1
- Misses 1583 1613 +30
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...la/src/main/scala/whisk/core/mesos/MesosTask.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NUYXNrLnNjYWxh) | `86.11% <ø> (ø)` | :arrow_up: |
| [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: |
| [...containerpool/kubernetes/KubernetesContainer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXIuc2NhbGE=) | `91.66% <ø> (ø)` | :arrow_up: |
| [...sk/core/containerpool/docker/DockerContainer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyLnNjYWxh) | `78.08% <0%> (+1.05%)` | :arrow_up: |
| [...ala/whisk/core/containerpool/ContainerClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJDbGllbnQuc2NhbGE=) | `0% <0%> (ø)` | |
| [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.23% <100%> (ø)` | :arrow_up: |
| [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `53.06% <14.28%> (+2.08%)` | :arrow_up: |
| [...ain/scala/whisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `75.38% <22.22%> (-0.81%)` | :arrow_down: |
| [...ols/admin/src/main/scala/whisk/core/cli/Main.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvTWFpbi5zY2FsYQ==) | `25.33% <0%> (-1.06%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=footer). Last update [c202ba7...29960b2](https://codecov.io/gh/apache/incubator-openwhisk/pull/3812?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services