You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/01/11 12:19:37 UTC

[GitHub] rafaelweingartner commented on a change in pull request #3125: IP address acquired with associate ip address is marked as source nat

rafaelweingartner commented on a change in pull request #3125: IP address acquired with associate ip address is marked as source nat
URL: https://github.com/apache/cloudstack/pull/3125#discussion_r247096894
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
 ##########
 @@ -1425,6 +1416,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long networkId, boolean
         }
     }
 
+    protected boolean isSourceNatAvailableForNetwork(Account owner, IPAddressVO ipToAssoc, Network network) {
 
 Review comment:
   Would you mind documenting this method? And explain in a few sentences, what it expect as input, the idea behind it, and then the possible output according to the inputs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services