[GitHub] [qpid-broker-j] overmeulen commented on a change in pull request #29: QPID-8304: [Broker-J][JDBC Message Store] Performance bottleneck at the level of the executor

[GitBox <gi...@apache.org>]

overmeulen commented on a change in pull request #29: QPID-8304: [Broker-J][JDBC Message Store] Performance bottleneck at the level of the executor
URL: https://github.com/apache/qpid-broker-j/pull/29#discussion_r280092613
 
 

 ##########
 File path: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
 ##########
 @@ -216,7 +216,7 @@ private void updateDbVersion(int newVersion) throws SQLException
     protected void initMessageStore(final ConfiguredObject<?> parent)
     {
         _parent = parent;
-        _executor = new ScheduledThreadPoolExecutor(4, new ThreadFactory()
+        _executor = new ScheduledThreadPoolExecutor(Runtime.getRuntime().availableProcessors(), new ThreadFactory()
 
 Review comment:
   I agree that hardcoding this value to 'availableProcessors' might not suit everyone.
   I'll do the change next week when I come back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org