You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/20 17:40:29 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #4252: Global JS functions from classpath/platform are reported as undeclared global variable
matthiasblaesing opened a new pull request, #4252:
URL: https://github.com/apache/netbeans/pull/4252
The JS hint, that detects undeclared global variables only queried the JS index for properties of the "window" object. This causes the variables and functions provided by the core- and dom-stubs to be mostly ignored.
This PR drops most of the hardcoded values in favor of querying the index.
The additional commits fix and reenable JS tests for CI/CD.
Closes: #4246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] qmegas commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
qmegas commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1285168875
My problem is that since NB 15 it looks like that:
<img src="https://user-images.githubusercontent.com/2444896/196902768-44c97746-6437-4efc-804b-e23208141a12.PNG">
Both `window` and `document` marked as not declared global variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1160739106
A test build is available here: https://doppel-helix.eu/NetBeans-dev-dev-305874798a712c97027ae7418159a185159c91e0-release.zip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1166241286
I intent to merge this some time next week. If anyone wants to object, please do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1285175326
@qmegas please open an issue rather than discussing on a merged pull request, and by the looks of it, share a minimal reproducible example so that you're discussing the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #4252:
URL: https://github.com/apache/netbeans/pull/4252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] qmegas commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
qmegas commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1284166456
@matthiasblaesing Can you please return `window` and `document` to the list of known global object? Or at least give us ability to edit the list from Netbeans settings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4252: Global JS functions from classpath/platform are reported as undeclared global variable
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4252:
URL: https://github.com/apache/netbeans/pull/4252#issuecomment-1284503070
What is your problem?
Hell, NetBeans does not only "know" that the objects are in the global scope, it even can do code completion on them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists