[jira] [Commented] (PIG-5226) PreprocessorContext.java can deadlock forever with large stderr

["Koji Noguchi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983267#comment-15983267 ] 

Koji Noguchi commented on PIG-5226:
-----------------------------------

Looks good.  Please add a license text to your new test {{TestPreprocessorContext.java}} file.
For the test path, I tend to put everything on test/org/apache/pig/test but probably your test/org/apache/pig/tools/parameters/TestPreprocessorContext is probably the right way.  Either way is fine.

> PreprocessorContext.java can deadlock forever with large stderr
> ---------------------------------------------------------------
>
>                 Key: PIG-5226
>                 URL: https://issues.apache.org/jira/browse/PIG-5226
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Jacob Tolar
>            Assignee: Jacob Tolar
>            Priority: Minor
>         Attachments: pig-runtime-exec.patch
>
>
> This code can deadlock on *nix (not sure about Windows...) because of how it's using {{Runtime.exec()}} (ie, stderr fills up its buffer and everything hangs). 
> Problematic snippet of code:
> https://github.com/apache/pig/blob/38c835ed702799f69dc2fa1ad0fbeab25e42c111/src/org/apache/pig/tools/parameters/PreprocessorContext.java#L238-L272



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)